Skip to content

Masked sdk key - #44

Open
kp-cat wants to merge 2 commits into
masterfrom
masked-sdk-key
Open

kp-cat wants to merge 2 commits into
masterfrom
masked-sdk-key

Conversation

@kp-cat

@kp-cat kp-cat commented Sep 16, 2026

Copy link
Copy Markdown
Member

Describe the purpose of your pull request

  • Mask the sdk key in logs
  • Sample sdk key update
  • Requirements cleanup

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@kp-cat
kp-cat requested a review from a team as a code owner September 16, 2026 22:07
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.53%. Comparing base (7ebc128) to head (d5cd09a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   98.52%   98.53%           
=======================================
  Files          40       40           
  Lines        3324     3340   +16     
=======================================
+ Hits         3275     3291   +16     
  Misses         49       49           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adams85 adams85 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with other SDKs, could you update the message for error 1100 to also include the masked SDK Key?

Sample: https://github.com/configcat/js-unified-sdk/blob/v1.1.0/src/ConfigCatLogger.ts#L212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants