Conversation
Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous release could report an uncaught exception and still exit successfully, accumulate shutdown callbacks when re-registered, and retry a failing reporter. This change reproduces and fixes those failures, then adds a service provider following FastForward's current callable definitions so applications can adopt the library through their container.
The unreleased next major targets PHP 8.3–8.5. It includes current Composer tooling, lowest/highest dependency CI, bounded fire tests, English API/migration/testing guides, static Pages documentation and weekly Dependabot updates. The existing
coisa/error-handlerpackage andCoiSA\ErrorHandlernamespace remain current; a possible future move to php-fast-forward has not been performed.The provider implements
Interop\Container\ServiceProviderInterfaceand reuses the existing PSR-11 factories. Resolving services never registers PHP callbacks. A process-handler alias and reusable factory services keep middleware handlers independent from the cached process service. FastForward remains optional at runtime; only the small Interop interface package is a new runtime dependency.The tested application wiring merges library definitions first and application definitions last in one
AggregateServiceProvider. This prevents an explicitly required reporter's PSR construction failure from falling back to the silent default. FastForward may still translate the cause to not-found; the contract promises failed construction, not preservation of the original exception. Integration guide and runnable example use this composition.AGENTS.md and the portable coisa-error-handler skill explain the actual public APIs, process/HTTP scopes, private reporting, fresh factories and verification. The skill retains its Composer package identity and public source link when copied into another project. No global skill installation is required.
Current head:
75137ca20aa825c6816b4c0b686a4a46fbd04003; PR base:f7284cdf9bda3fadfe33f107d2c0fed3e38962cd. Full local runtime evidence below was recorded at8646c73971ef9c6024048202a508cbb66960a274. The later five-file skill identity/documentation change received separate independent approval; runtime, dependencies and workflows are unchanged. Current-head CI passed separately.The baseline fire-test results and earlier platform evidence remain in the testing contract. Migration guidance covers exit status 1 for uncaught exceptions, reverse-order unregistration, reporter failure handling and redacted HTTP responses.
Limits: FPM, Apache, Windows, concurrent request runtimes, arbitrary OOM recovery and remote logger delivery require application-specific validation. PHP callbacks are process-wide. Renderers must balance removable buffers and must not close caller-owned buffers. Pages publication is manual and restricted to
master; no merge, release, transfer or deployment is included.Closes #2.