fix(HTTP): strip CRLF from DownloadResponse filename to prevent header injection - #10533
Closed
gr8man wants to merge 2 commits into
Closed
fix(HTTP): strip CRLF from DownloadResponse filename to prevent header injection#10533gr8man wants to merge 2 commits into
gr8man wants to merge 2 commits into
Conversation
neznaika0
suggested changes
Sep 9, 2026
| { | ||
| $filename = $this->filename; | ||
| $x = explode('.', $this->filename); | ||
| $filename = str_replace(["\r", "\n"], '', $this->filename); |
Contributor
There was a problem hiding this comment.
If we don’t use Reflection magic, then there’s no need to sanitize the file name — it’s already safe from the setter.
…r injection Sanitize carriage return and newline characters from filename in DownloadResponse to prevent HTTP response splitting and invalid header values per RFC 7230.
gr8man
force-pushed
the
fix/download-response-crlf
branch
from
September 9, 2026 18:34
5d6e5ff to
87ac5fa
Compare
michalsn
reviewed
Sep 10, 2026
michalsn
left a comment
michalsn
left a comment
Member
There was a problem hiding this comment.
Thanks, but running the new tests against the unchanged develop source already throws an InvalidArgumentException before headers are sent. I also checked the constructor and setter cases separately - both are rejected. Without a clear justification for changing from rejection to silent sanitization, I'm not comfortable merging this.
Please report suspected security vulnerabilities privately through our security reporting process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
DownloadResponse, filenames with carriage return (\r) or newline (\n) characters could cause RFC 7230 header validation errors or lead to HTTP header injection / response splitting.This PR strips
\rand\ncharacters from the filename when setting it onDownloadResponse.Checklist: