fix: Validate and sanitize Codecov token before use in Authorization header - #780
Open
sentry[bot] wants to merge 1 commit into
Open
fix: Validate and sanitize Codecov token before use in Authorization header#780sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an
InvalidHeadererror that occurred when theCODECOV_TOKENenvironment variable (or-tflag) contained a YAML-structured multi-line string (e.g.,codecov:\n token: <UUID>) instead of the plain UUID token.The
requestslibrary, used for HTTP communication, rejects header values containing newline or carriage-return characters. Previously, the CLI would pass the malformed token directly, leading to a crash.To fix this, a new helper function
_validate_tokenhas been introduced incodecov_cli/helpers/request.py. This function:\n) or carriage-return (\r) characters within the token.click.ClickExceptionwith a clear, actionable error message, guiding the user to provide only the plain UUID token.This validation is applied in both
get_token_header_or_failandget_token_headerto ensure all Authorization headers are properly formed, preventing crashes and improving user experience for misconfigured tokens.Fixes CLI-GT
This PR was automatically generated by Sentry. You can adjust this setting at any time.