Skip to content

fix: handle FileNotFoundError for temporary coverage files #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle FileNotFoundError for temporary coverage files #779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions codecov_cli/services/upload/upload_sender.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,10 +189,21 @@ def _get_file_fixers(
return file_fixers

def _get_files(self, upload_data: UploadCollectionResult):
return [self._format_file(file) for file in upload_data.files]
return [
result
for result in (self._format_file(file) for file in upload_data.files)
if result is not None
]

def _format_file(self, file: UploadCollectionResultFile):
format, formatted_content = self._get_format_info(file)
try:
format, formatted_content = self._get_format_info(file)
except FileNotFoundError:
logger.warning(
f"Coverage file not found, skipping: {file.get_filename()}. "
"The file may have been removed before upload (e.g. a temporary coverage file cleaned up by the test framework)."
)
return None
return {
"filename": file.get_filename(),
"format": format,
Expand Down
Loading