fix: retryFailedStep plugin works in debug/verbose mode - #5128
Conversation
|
|
||
| const when = err => { | ||
| if (!enableRetry) return false | ||
| if (store.debugMode) return false |
There was a problem hiding this comment.
Not sure if the fix is needed here too, because enhancedRetryFailedStep plugin seems the quite hot new feature: #5103
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the retryFailedStep and enhancedRetryFailedStep plugins were disabled when running CodeceptJS with --verbose or --debug flags. The fix removes the debugMode check that prevented retries from working in debug mode.
- Removes
if (store.debugMode) return falsecheck from both retry plugins - Adds regression test to verify retries work correctly when debugMode is enabled
- Ensures retry functionality is available regardless of debug/verbose mode settings
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/plugin/retryFailedStep.js | Removes debugMode check that blocked retries in debug mode |
| lib/plugin/enhancedRetryFailedStep.js | Removes debugMode check that blocked retries in debug mode |
| test/unit/plugin/retryFailedStep_test.js | Adds regression test to ensure retries work in debug mode |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- Remove debugMode check that prevented retries when --verbose or --debug flags are used - Add regression test to ensure retries work correctly in debug mode - Resolves issue where plugin was disabled in debug mode without clear reason Fixes codeceptjs#4384 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
f5cc169 to
c156f79
Compare
|
@kobenguyent @DavertMik The issue was already reported (and PR created) in 3.x and I today I solved conflicts with 4.x: |
Fixed by VSCode Copilot with Claude Sonnet 4.
Personally I checked that the added unit test fails as expected before the fix.
Motivation/Description of the PR
Fixes #4384
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)