Skip to content

thread-safe LOG_PERIODICALLY - #7327

Merged
mikea merged 1 commit into
mainfrom
maizatskyi/2026-09-11-log-periodically
Sep 15, 2026
Merged

mikea merged 1 commit into
mainfrom
maizatskyi/2026-09-11-log-periodically

Conversation

@mikea

@mikea mikea commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@mikea
mikea requested review from a team as code owners September 11, 2026 20:59
Comment thread src/workerd/util/sentry.h
@ask-bonk

ask-bonk Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

I'm Bonk, and I've done a quick review of your PR.

Makes LOG_PERIODICALLY timestamp access atomic and adds a concurrency test.

  1. High: src/workerd/util/sentry.h:82 still permits concurrent duplicate logs due to a check-then-store race. Posted a suggestion using atomic compare-and-exchange.

github run

@mikea
mikea enabled auto-merge September 11, 2026 21:03
@mikea
mikea force-pushed the maizatskyi/2026-09-11-log-periodically branch from a330c42 to 4886a67 Compare September 15, 2026 15:49
@mikea
mikea merged commit 0afb71f into main Sep 15, 2026
22 of 23 checks passed
@mikea
mikea deleted the maizatskyi/2026-09-11-log-periodically branch September 15, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants