chore: improve product labeling for issues and changelogs - #33394
Merged
Merged
Conversation
mvvmm
marked this pull request as ready for review
September 11, 2026 16:32
mvvmm
requested review from
a team,
MohamedH1998,
ahaywood and
colbywhite
as code owners
September 11, 2026 16:32
Contributor
Review✅ No issues found in commit Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://chore-improve-product-labeling.previews.developers.cloudflare.com (commit cb94361)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Collaborator
Author
|
/rebase |
mvvmm
force-pushed
the
chore/improve-product-labeling
branch
from
September 11, 2026 17:31
137bf67 to
5ada10d
Compare
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
|
Preview URL: https://cb943610.preview.developers.cloudflare.com |
- readDir now fails loudly instead of returning [] on error, so a missing/renamed primary input dir aborts instead of silently dropping product rules and overwriting labeler.yml - refuse to write labeler.yml when no rules were generated - merge special rule globs with any existing rule instead of overwriting, so a future docs dir named changelog/email-routing wouldn't silently replace the special rule Regenerating also picks up src/assets/images/sandbox/** for product:sandbox (previously missed due to a stale working tree).
- firstUrlSegment now normalizes absolute URLs via new URL().pathname, so an absolute entry.url/productLink no longer yields a bogus 'https:' segment - share the changelog folder alias map between content and image changelog mappings instead of only applying it to images - skip (with a warning) changelog folders that have no directory entry or no entry.url instead of crashing the generator
Only skip changelog folders missing a directory YAML (ENOENT) and rethrow parse/other I/O errors; guard URL parsing so malformed URLs skip the entry instead of crashing the generator.
mvvmm
force-pushed
the
chore/improve-product-labeling
branch
from
September 14, 2026 19:33
6313b40 to
1a49b17
Compare
ahaywood
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves product labeling across issues and PRs:
product:label, so/API/...producesproduct:apiinstead of creating a separateproduct:APIlabel.product:_headersandproduct:_redirects— those map root config files, not products.product:workers) and the existingproduct:changeloglabel.bin/generate-labeler.ts(pnpm run generate:labeler) that regenerates.github/labeler.ymlfrom the content collections. The labeler header previously claimed the file was generated but no generator was committed.The changelog mapping is derived from
src/content/directory/*.yamlentry.urlfirst segments (e.g. Zero Trust sub-products likeaccess,gateway,casbmap tocloudflare-one).Behavior note: deriving release-notes from
productLinkalso adds three previously-unlabeled release-notes files (workers.yaml,workflows.yaml,zaraz.yaml) to their product rules — a change to those files previously got no product label.