ENT-14171: Replaced ! cmd with if assertions to exit correctly with set-e - #340
Merged
Merged
Conversation
SimonThalvorsen
changed the title
! grep with if assertions to exit correctly with set-e! grep with if assertions to exit correctly with set-e
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #340 +/- ##
=======================================
Coverage 67.71% 67.71%
=======================================
Files 24 24
Lines 4640 4640
=======================================
Hits 3142 3142
Misses 1498 1498 🚀 New features to boost your workflow:
|
Ticket: ENT-14171 Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
SimonThalvorsen
force-pushed
the
ENT-14171
branch
from
September 15, 2026 11:49
df69bcc to
30c1272
Compare
SimonThalvorsen
changed the title
! grep with if assertions to exit correctly with set-e! cmd with if assertions to exit correctly with set-e
larsewi
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: ENT-14171