Copy arm64 files for AnyCpu builds - #5288
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe MSBuild targets now define an AnyCPU ARM64 output directory. The ChangesAnyCPU ARM64 packaging
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The change adds ARM64 runtime files to AnyCPU build outputs; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description includes the linked issue, summary, detailed changes, testing steps, change type, and checklist. The omitted screenshots section is not required because screenshots are not appropriate for this build-target change. Full details: Linked Issues checkExplanation The changes support issue Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Build CefSharp 150.0.110-CI5605 completed (commit 8966f2e74e by @drymay82) |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Addition to PR: #5267
Fixes: #4155
Summary:
Changes:
CefSharpTargetDirAnyCpuArm64, resolving toarm64\.CefSharpBuildAction=NoneAnyCPU path, adds ARM64 copies for:@(CefRedistArm64)— CEF redistribution/native resources@(CefSharpCommonBinariesArm64)—CefSharp.Core.Runtime.dll, browser subprocess files, etc.@(CefSharpCommonManagedDll)—CefSharp.dll, required by the architecture-specific browser subprocess folderCefSharpBuildAction=ContentAnyCPU path.How Has This Been Tested?
netarm64branch including my changes<CefSharpAnyCpuSupport>true</CefSharpAnyCpuSupport> <CefSharpPlatformTargetOverride>AnyCPU</CefSharpPlatformTargetOverride> <PreferNativeArm64>true</PreferNativeArm64Process architecture: Arm64 Expected runtime: ...\arm64\CefSharp.Core.Runtime.dll Expected CEF runtime: ...\arm64\libcef.dllI also validated these changes the same way in our product’s cefsharp-browser application: it builds as AnyCPU with the ARM64 CefSharp runtime included and prefers native ARM64 execution on supported Windows devices.
Types of changes
Checklist:
Summary by CodeRabbit