Fix single-quoted environment values retaining their quotes - #89
Open
Ishubhammohole wants to merge 1 commit into
Open
Ishubhammohole wants to merge 1 commit into
Ishubhammohole wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
mvn -B -Dtest=QuotedValuesTests -Djavadoc.dir=target/generated-javadoc testbefore the fix: 2 failures, 1 pass.mvn -B -ntp -Djavadoc.dir=target/generated-javadoc clean test jacoco:report packagewith Java 11: successful, all 30 tests passed.mvn -B -ntp -Djavadoc.dir=target/generated-javadoc testafter the final edit: all 30 passed.git diff --check: passed.mvn checkstyle:checkwith changed-file includes used the default Sun rules and failed; the unchanged parser also reports 44 violations. The configured Docker-based pre-commit hook could not run because the Docker daemon is unavailable.The Javadoc directory override keeps build output under target instead of modifying tracked documentation. Prepared with Codex assistance.
Fixes #81