deploy.yml checked less than it said - #22
Merged
Merged
Conversation
…w a second checkout The gate now reads two repositories: cap2UI5 for paths, app ids, the plugin's exports and options, and abap2UI5 for the framework class names, which are not in cap2UI5 at all. check.yml got the second checkout. deploy.yml did not - and it runs the LENIENT `npm run check`, which skips the checks a missing checkout would need and exits 0. So the deploy job went green while silently not checking a single z2ui5 class on the site. It published in that state once already, today. That is the exact failure mode the comment in verify-refs.mjs describes - "a workflow that checks cap2UI5 out and then silently loses it would go on passing while checking nothing" - reached from the other direction: not by losing a checkout, but by adding a requirement to the checker and not to the workflow. Both CI jobs now run `check:ci` with both checkouts. `npm run check` stays what it was for: a contributor's machine, where a missing clone is a setup gap rather than a broken pipeline. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JoANwtaK8Jm9srGEqSxmUF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A gap I introduced in #21 and caught reading the post-merge deploy run.
verify-refs now reads two repositories: cap2UI5 for paths, app ids, the plugin's exports and options, and abap2UI5 for the framework class names, which are not in cap2UI5 at all.
check.ymlgot the second checkout.deploy.ymldid not — and it runs the lenientnpm run check, which skips the checks a missing checkout would need and exits 0.So the deploy job went green while silently not checking a single
z2ui5_*class on the site. It published in that state once already, today.That is the exact failure mode the comment in
verify-refs.mjsdescribes — "a workflow that checks cap2UI5 out and then silently loses it would go on passing while checking nothing" — reached from the other direction: not by losing a checkout, but by adding a requirement to the checker and not to the workflow.Both CI jobs now run
check:ciwith both checkouts.npm run checkstays what it is for: a contributor's machine, where a missing clone is a setup gap rather than a broken pipeline.🤖 Generated with Claude Code
https://claude.ai/code/session_01JoANwtaK8Jm9srGEqSxmUF
Generated by Claude Code