Skip to content

test: enable lambda Node-API examples - #457

Open
huytdps13400 wants to merge 1 commit into
callstackincubator:nextfrom
huytdps13400:fix/423-enable-lambda-examples
Open

test: enable lambda Node-API examples#457
huytdps13400 wants to merge 1 commit into
callstackincubator:nextfrom
huytdps13400:fix/423-enable-lambda-examples

Conversation

@huytdps13400

Copy link
Copy Markdown

Summary

  • enable the three upstream Node-API examples that were skipped for lambda support
  • add each example to the mobile runtime suite with exact output assertions
  • remove the stale lambda TODOs; the current gyp-to-cmake CLI already emits cxx_std_17, so no transformer workaround is needed

This addresses the lambda portion of #423. The independent noexcept and output-directory items remain out of scope.

Verification

  • pnpm run build
  • pnpm test
  • pnpm run lint
  • pnpm run prettier:check
  • Apple: all three examples compiled into universal iOS Simulator XCFrameworks
  • Android: all three examples compiled for arm64-v8a, armeabi-v7a, x86, and x86_64

Note

node-addon-examples verify expects a release-style Apple build containing both the ios-arm64 device slice and the simulator slice. The local current-development build produces only the universal simulator slice, so that verifier stops on the pre-existing async-work example before reaching any newly enabled example. Both native platform builds above complete successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant