fix(ios): keep the original error message for script download failures - #1449
Open
yunsung-miso wants to merge 2 commits into
Open
fix(ios): keep the original error message for script download failures#1449yunsung-miso wants to merge 2 commits into
yunsung-miso wants to merge 2 commits into
Conversation
NSURLError leaves localizedFailureReason nil, so the reject block received a nil message and React Native replaced it with "Unknown error from a native module". Every transport-level failure therefore looked identical in production logs. Fall back to localizedDescription, append the error domain and code, and pass the NSError through so its userInfo survives. The reject code stays ScriptDownloadFailure, so the retry gate in loadScriptWithRetry is unaffected.
|
@yunsung-miso is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 2d8fb1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1448.
On iOS, every transport-level script download failure reached JavaScript as
Unknown error from a native module, so a timeout, a dropped connection and a TLS failure were indistinguishable in production logs.downloadAndCachehands itsNSErrorto the reject block aserror.localizedFailureReason.NSURLErrorleaves that propertynil, and React Native substitutes its own fallback string whenever the message isnil. HTTP status failures were unaffected only becausedownloadAndCachebuilds those errors itself and setsNSLocalizedFailureReasonErrorKeyexplicitly — which is what made the gap easy to miss.Android already falls back with
e.message ?: e.toString()inRemoteScriptLoader.kt, so this brings iOS in line.Changes
DescribeScriptDownloadError, which falls back tolocalizedDescriptionand appends the error domain and code.ScriptDownloadFailurereject sites (loadScript,prefetchScript), and pass theNSErrorthrough as the third argument souserInfosurvives the bridge.Before:
Unknown error from a native moduleAfter:
The request timed out. (NSURLErrorDomain -1001)Compatibility
The reject code stays
ScriptDownloadFailure, so the retry gate inloadScriptWithRetry(LOADING_ERROR_CODES) behaves exactly as before. Only the message and the attached error change.Test plan
timeout(Network Link Conditioner, 3G profile) and confirm the rejection now names the failure.Request should have returned with 200 HTTP status, but instead it received 403.