refactor: inline Platform.OS checks - #5087
Merged
Merged
Conversation
Collaborator
|
#5078 landed since you opened this and deleted most of what it touches - the |
michalfedyna
changed the title
MikitasK
added a commit
to burczu/react-native-paper
that referenced
this pull request
Sep 5, 2026
…into feat/tooltip-md3-modernization Conflicts resolved: - Tooltip.tsx: kept the rewritten trigger and singleton-slot show/hide; upstream had only inlined the `isWeb` check, which the merge already picked up. - migration.md: kept both the upstream v6 sections and the Tooltip one. - jest/testSetup.js: took upstream's setup. It stops mocking react-native-reanimated altogether, so the local `cubicBezier` stub the branch added to the mock is no longer needed. - FAB/Extended.tsx: took upstream's `Platform` value import, kept `View` as a type-only import (it is only used for the ref type). - FAB/Shell.tsx: kept both sides of the reanimated import. - FABExtended.test.tsx: unioned both import lists. Adapted to upstream: - `../../types` is gone (callstack#5098/callstack#5087); Tooltip/hooks.ts and RichTooltip.tsx now import from `theme/types`. - Surface's `style` no longer configures background or radius (callstack#5078); the rich tooltip passes `backgroundColor` and `borderRadius` as props.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Inline
Platform.OScode so minifier can remove dead code.Related issue
Inline
Platform.OScode so minifier can remove dead code.Test plan
Look if replacement was done correctly.