K0ndee/split button - #5077
Draft
k0ndee wants to merge 8 commits into
Draft
Conversation
Removes the no-op mode normalization, derives the disabled outlined border color from onSurface per MD3 tokens, drops the unused elevation.pressed token and the leading/style prop omissions that View doesn't have, replaces icon-label spacing and the hardcoded touch-target size with proper tokens, avoids a redundant font style on the label, adds a sizes example, and trims utils unit tests down to public component behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Implements the new Material Design 3 SplitButton component as part of the v6 component modernization work.
The component provides a primary leading action and a separate trailing action for contextual options. It reuses the modernized Button API direction
from #4928/#4943: explicit
label/iconprops, MD3 mode names (filled,tonal,elevated,outlined), derived ripple/state-layer colors,extracted component tokens, size metrics, shape tokens, disabled/loading states, and separate accessibility/press handlers for each button segment.
This also adds the component to the public exports, documentation generation config, theme color docs data, and the example app. The example includes a
Menu-based playground, mode showcase, loading/disabled controls, and custom color/label styling.
Related issue
Closes #4986
Related to #4928 and #4943
Is a follow up to #4998
Test plan
yarn lint-no-fixsrc/components/__tests__/TextInput.test.tsx.yarn typescriptyarn test --watchman=falseyarn docs buildManual verification in the example app:
SplitButtonexample screen.Sendaction and trailing menu action separately.Disabledand verify both press targets are disabled and styled correctly.Loadingand verify the leading icon is replaced with a spinner.filled,tonal,elevated, andoutlined.