Skip to content

refactor: prune platform split residue - #2123

Merged
thymikee merged 1 commit into
refactor/retire-platforms-seamfrom
refactor/prune-platform-split-residue
Aug 29, 2026
Merged

refactor: prune platform split residue#2123
thymikee merged 1 commit into
refactor/retire-platforms-seamfrom
refactor/prune-platform-split-residue

Conversation

@thymikee

Copy link
Copy Markdown
Member

Summary

Prune the dead policy, export, and routing residue left after the platform-package split. This is stacked on #2119.

  • remove the unconsumed Apple interactions and runner/client package subpaths plus redundant Android IME and provision boot-diagnostics re-exports
  • remove unreachable src/platforms workflow filters and duplicate daemon-modularity rules while preserving the retired-zone and R65 resurrection guards
  • remove the orphaned Fallow suppression, repair moved baselines/docs, and lock six smaller eager import closures

Validation

  • planted-red package-boundary and routing cases failed against the pre-cleanup tree, then passed after the removals
  • node --experimental-strip-types --test scripts/gate/routing.test.ts scripts/layering/package-boundaries.test.ts scripts/layering/platform-package-policy.test.ts scripts/layering/daemon-modularity.test.ts (63 passed)
  • focused Vitest suites (461 passed)
  • production-unused exports: 28 -> 26, with no unused files or unresolved imports
  • pnpm check:affected --run passed formatting, lint, typecheck, layering, Fallow, build, package, and integration checks; the related suite passed 2,985/2,986 tests, with one unrelated timer-based gesture-policy test timing out only under four-worker load and passing 4/4 in isolation

@github-actions

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 2.51 MB 2.51 MB 0 B
JS gzip 839.3 kB 839.4 kB +98 B
npm tarball 966.7 kB 966.8 kB +98 B
npm unpacked 3.35 MB 3.35 MB 0 B

npm unpacked components

Component Base Current Diff
JS / dist source 2.66 MB 2.66 MB 0 B
Apple runner source/project 581.1 kB 581.1 kB 0 B
macOS helper source 54.8 kB 54.8 kB 0 B
Android helper artifacts 0 B 0 B 0 B
Other package files 45.6 kB 45.6 kB 0 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 31.0 ms 34.0 ms +3.0 ms
CLI --help 82.6 ms 85.7 ms +3.2 ms

Top changed chunks:

Chunk Raw diff Gzip diff
dist/src/mechanics.js 0 B +88 B
dist/src/session2.js 0 B +10 B

Top changed packed files

No changed packed files.

@thymikee

Copy link
Copy Markdown
Member Author

Independent review found no code-level blocker on exact head 8d94bf5219f0b96dd060f0eaf398dacdd3185732. The removed Apple export-map entries have no remaining repository consumer; the live path keeps interactor and runner-client construction package-internal, consistent with ADR 0019/R13. The routing and export-map tests provide real planted-red protection, and exact-head CI is green.

One stack blocker remains: this PR is based on open #2119, whose exact head still has a failed iOS smoke. #2123's own iOS run passed, but clear or rerun #2119 before treating this stack layer as merge-ready.

@thymikee

Copy link
Copy Markdown
Member Author

Dependency update: #2119’s failed iOS job was rerun against its exact head and is now green, including the previously failing fixture-backed simulator E2E step. The stack-level CI blocker called out here is cleared.

@thymikee

Copy link
Copy Markdown
Member Author

Re-verified exact head 8d94bf5219f0b96dd060f0eaf398dacdd3185732: #2123's checks remain green and it is mergeable. Its direct prerequisite #2119 is also mergeable, with the previously failed iOS smoke rerun green on its unchanged exact head. The stack-level CI blocker is cleared; this layer is ready for human review in stack order after #2119.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Aug 28, 2026
@thymikee
thymikee merged commit a6232e5 into main Aug 29, 2026
13 checks passed
@thymikee
thymikee deleted the refactor/prune-platform-split-residue branch August 29, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant