Conversation
adamrk
commented
Sep 22, 2026
Comment on lines
6
to
+20
| @@ -16,13 +17,13 @@ fn main() { | |||
| meta.workspace_root.as_os_str().to_str().unwrap() | |||
| ); | |||
|
|
|||
| fn build_targets(pkg: &str, manifest: &str, kind: &str, out_dir: &PathBuf) { | |||
| fn build_target(pkg: &str, manifest: &str, kind: &str, target: &str, out_dir: &Path) { | |||
Contributor
Author
There was a problem hiding this comment.
Had to make some changes here to get the test programs running for both targets. We also need to detect the nightly toolchain to only run the p3 tests when using nightly.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #155
Here the p2 and p3 backends have completely different implementations because the underlying streams are quite different. Notably,
flushbecomes a no-op onp3streams because they have no notion offlushing. However, we are able to implementflushforStdoutandStderr.