fix(pg): run a named statement with an empty text more than once - #3781
Open
nigrosimone wants to merge 3 commits into
Open
nigrosimone wants to merge 3 commits into
nigrosimone wants to merge 3 commits into
Conversation
nigrosimone
marked this pull request as ready for review
September 13, 2026 11:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client.query({ text: '', name: 'empty' })works once and fails from the second run on withprepared statement "empty" already exists. OnParseCompletethe client records the name with its text,'', andhasBeenParsedthen tests that text for truth, so the statement is read as never parsed and is sent to Parse again. The native client keeps its own map of names and reads it the same way.The fix checks both caches by presence rather than by the truth of the text.
The added test runs a named empty statement twice: it fails on master, on both clients, and passes here.