fix(pg-protocol): keep the bytes of binary columns instead of decoding them as text - #3777
Closed
nigrosimone wants to merge 2 commits into
Closed
nigrosimone wants to merge 2 commits into
nigrosimone wants to merge 2 commits into
Conversation
nigrosimone
marked this pull request as ready for review
September 13, 2026 10:57
Collaborator
Contributor
Author
|
Oook 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3495. With
binary: truethe parser decodes everyDataRowfield as utf8 text, andResultturns the string back into a Buffer before the type parser runs. Any byte utf8 cannot carry is replaced on the way, soSELECT 1000::int4comes back as 1007 and200as 239.The row description says which columns are binary. The parser now remembers that and hands those fields over as bytes, the text columns as strings like before, so a query without binary columns pays one null check per row.
Two tests: the parser one feeds a binary row description and a row with the bytes of 1000, the pg one runs a binary query with an int4, a float8 and a non-ascii text. Both fail on master and pass here.
Built on #3776, which makes
BufferReader.bytesreturn a copy; the first commit is that one.