Skip to content

feat: Ports command polish - #478

Merged
patelspratik merged 2 commits into
mainfrom
dm/ports-and-externalnode
Sep 17, 2026
Merged

patelspratik merged 2 commits into
mainfrom
dm/ports-and-externalnode

Conversation

@drewmalin

@drewmalin drewmalin commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Updates the ports command tree:

  • Collapses HTTP and TCP/UDP into a single table, incudes port ID
  • Allows for get on a single port, which includes all data in a list
  • Uses open and remove/rm for creating and deleting ports
  • Allows port removal or read to target the destination of an indicated instance or the unique port ID
  • Allows sequential port allocation
  • Allows updating of port details
  • Includes port type in get/json data

Somewhat unrelated, but this also starts to use the "Brev Connect" terminology more explicitly, rather than the "external" naming.

Screen.Recording.2026-09-15.at.17.25.26.mov

@drewmalin
drewmalin marked this pull request as ready for review September 16, 2026 00:30
@drewmalin
drewmalin requested a review from a team as a code owner September 16, 2026 00:30
@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.65729% with 103 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.86%. Comparing base (17ccd79) to head (9ce9800).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/ports/ports.go 70.29% 22 Missing and 8 partials ⚠️
pkg/cmd/ports/open.go 83.33% 14 Missing and 6 partials ⚠️
pkg/cmd/ports/close.go 75.71% 13 Missing and 4 partials ⚠️
pkg/cmd/cmd.go 0.00% 14 Missing ⚠️
pkg/cmd/ports/get.go 80.70% 8 Missing and 3 partials ⚠️
pkg/cmd/ls/ls.go 0.00% 6 Missing ⚠️
pkg/cmd/ports/update.go 75.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   24.67%   31.86%   +7.18%     
==========================================
  Files         134      153      +19     
  Lines       18337    21709    +3372     
==========================================
+ Hits         4525     6917    +2392     
- Misses      13335    14053     +718     
- Partials      477      739     +262     
Flag Coverage Δ
Linux 31.86% <73.65%> (+7.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@patelspratik
patelspratik merged commit 15c0787 into main Sep 17, 2026
11 checks passed
@patelspratik
patelspratik deleted the dm/ports-and-externalnode branch September 17, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants