Conversation
Contributor
|
#187 was no longer a valid issue; it looks like the problem being reported there was fixed long ago and we missed closing the issue. This PR would only change the behavior if the executable is some mapping other than the first one, but I don't believe that's possible - and even if it was, choosing an arbitrary different mapping would certainly not be the right fix; that might just select a shared library rather than the executable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #187
When a core file is generated from a Python script executed directly via a shebang, \extract_executable()\ returns the path to the script (which is not an ELF file). Previously, Pystack would only check the first map with a path to see if it was an ELF. If it wasn't, Pystack failed with \InvalidExecutable.
This PR iterates through the maps to find the first map that is a valid ELF file, successfully locating the underlying python interpreter.