Improve handling for invalid core files - #358
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
==========================================
+ Coverage 78.19% 78.75% +0.56%
==========================================
Files 58 58
Lines 6690 6709 +19
Branches 630 632 +2
==========================================
+ Hits 5231 5284 +53
+ Misses 1459 1425 -34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
godlygeek
force-pushed
the
handle_bad_core_files
branch
2 times, most recently
from
September 18, 2026 17:18
d51c2b6 to
cf28439
Compare
godlygeek
changed the title
godlygeek
force-pushed
the
handle_bad_core_files
branch
from
September 18, 2026 18:16
cf28439 to
11d9cb4
Compare
blin
reviewed
Sep 21, 2026
Contributor
Author
|
OK, I've pushed a fixup commit that I believe addresses all of your concerns. If you're happy with the results, lmk and I'll squash and merge. |
blin
approved these changes
Sep 22, 2026
Prevent reading past the end of a truncated or malformed core file's `NT_FILE` note. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
godlygeek
force-pushed
the
handle_bad_core_files
branch
from
September 22, 2026 15:13
5cec815 to
e0d0aed
Compare
godlygeek
enabled auto-merge (rebase)
September 22, 2026 15:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent reading past the end of a truncated or malformed core file's
NT_FILEnote.