Use JSON 3 compatible multi_json in Apollo fixture - #1391
Merged
Merged
Conversation
jwils
marked this pull request as ready for review
September 14, 2026 15:41
jwils
requested review from
BrianSigafoos-SQ,
bsorbo,
ellisandrews-toast,
jwondrusch,
marcdaniels-toast,
myronmarston and
rossroberts-toast
as code owners
September 14, 2026 15:41
jwils
changed the title
myronmarston
approved these changes
Sep 14, 2026
myronmarston
left a comment
myronmarston
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for tackling this!
jwils
force-pushed
the
joshuaw/constrain-apollo-json
branch
from
September 14, 2026 21:53
948c29a to
e806ca9
Compare
jwils
enabled auto-merge (squash)
September 14, 2026 21:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Apollo compatibility fixture runs
bundle installwithout a lockfile. It can selectjson 3.0.0, but the oldermulti_json 1.21.1passes parser options in the format JSON 3 no longer accepts.What
Require a JSON 3-compatible
multi_jsonrelease for the fixture.How
Add
multi_json "~> 1.21", ">= 1.21.2"toelasticgraph-apollo/apollo_tests_implementation/Gemfile. This permits compatible future 1.x releases while excluding 1.21.1 and older releases. The minimum version has passed the repository cooldown.Risk
This only changes dependency resolution for the Apollo compatibility test fixture. It does not change production gem dependencies or runtime code.
Testing
No manual testing. CI runs the Apollo compatibility checks.