Conversation
🔐 Codex Security Review
|
Bartok9
force-pushed
the
bartok/fix-acp-windows-dns-errno-7512
branch
2 times, most recently
from
September 14, 2026 13:16
8fe2a8c to
9845310
Compare
…ckoff is_dns_error only matched English resolver strings and one Windows code (11001). WSANO_DATA (11004) and WSATRY_AGAIN (11002) therefore burned autonomous-reconnect ladder rungs on transient getaddrinfo brownouts. Match raw_os_error() first (language-independent), keep string fallback for flattened Http errors, and leave WSANO_RECOVERY (11003) off the DNS path. Fixes block#7512. Signed-off-by: Bartok9 <259807879+Bartok9@users.noreply.github.com>
Bartok9
force-pushed
the
bartok/fix-acp-windows-dns-errno-7512
branch
from
September 16, 2026 13:17
9845310 to
f90cd15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_dns_erroronly matched English resolver strings plus one Windows code (11001/WSAHOST_NOT_FOUND). Production logs in #7512 showWSANO_DATA(os error 11004) taking the backoff ladder while11001correctly used the DNS flat retry.Change
raw_os_error()onRelayError::WebSocket(Io(_))so classification is independent of Windows display language.11001,11002(WSATRY_AGAIN), and11004as transient DNS. Leave11003(WSANO_RECOVERY) off that path.RelayError::Http.is_windows_dns_errnois a purei32matcher so Linux CI can assert the Windows path.Fixes #7512
Test plan
cargo test -p buzz-acp --lib is_dns_error