Add ShellForEach method for running per-line commands via the system shell - #246
Open
ChrisJr404 wants to merge 1 commit into
Open
Add ShellForEach method for running per-line commands via the system shell#246ChrisJr404 wants to merge 1 commit into
ChrisJr404 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from the discussion in #184, this adds
ShellForEach, the per-line companion to the newShellmethod.ExecForEachsplits each rendered command withshell.Fields, so a template value containing spaces gets broken up into separate arguments (thetouch {{.}}on a filename with spaces problem in that issue).ShellForEachpasses each rendered line to the system shell instead, so you can quote the value and let the shell deal with it:Under the hood it runs each line through
sh -c(cmd /Con Windows) the same wayShelldoes, and the error handling, environment, and context behaviour all matchExecForEach. Added the docs, an example, and tests including the quoted-argument case.