Conversation
Introduce the draft BCH_2027_05 instruction set, adding OP_SIGHASH at 0xbd. The operation pops a sighash-type byte, validates it against the same types as OP_CHECKSIG, computes the identical sighash preimage, and pushes the single-SHA256 digest (dropping straight into OP_CHECKDATASIG). - Retarget BCH_SPEC onto BCH_2027_05 - Extend VMB test plumbing (2027 sets, 2026_invalid override) and add core.sighash test sources - Enable BCH_2027_05 in standard templates and unit tests Generated VMB vectors and BCHN expected-test results are deferred and will come in a follow-up commit. Signed-off-by: James Zuccon <zuccon@gmail.com>
🦋 Changeset detectedLatest commit: da9acf7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #164 +/- ##
==========================================
- Coverage 95.82% 94.12% -1.70%
==========================================
Files 161 170 +9
Lines 54119 54806 +687
Branches 1820 1680 -140
==========================================
- Hits 51857 51588 -269
- Misses 2261 3216 +955
- Partials 1 2 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(DRAFT: Do not review yet.)
Introduce the draft BCH_2027_05 instruction set, adding OP_SIGHASH at 0xbd. The operation pops a sighash-type byte, validates it against the same types as OP_CHECKSIG, computes the identical sighash preimage, and pushes the single-SHA256 digest (dropping straight into OP_CHECKDATASIG).
Generated VMB vectors and BCHN expected-test results are deferred to ease review and will come in a follow-up commit.