fix(runtime): preserve inherited run bundle ownership - #2080
Merged
codeforester merged 1 commit intoSep 3, 2026
Merged
codeforester merged 1 commit into
codeforester merged 1 commit into
Conversation
codeforester
deleted the
bug/2069-20260902-prevent-delegated-base-children-from-finalizing-inherited-ru
branch
September 3, 2026 07:32
This was referenced Sep 3, 2026
codeforester
added a commit
that referenced
this pull request
Sep 3, 2026
## Summary - Keep completion history ownership with the invocation that created the run bundle. - Prevent inherited Base children from marking the parent bundle complete. - Clarify the delegated-history contract and add regression coverage. ## Issue Fixes #2083 Follow-up to #2080. ## Validation - `bats --print-output-on-failure cli/bash/commands/basectl/tests/runtime-dispatch.bats` — 40 passed - `bats --print-output-on-failure cli/bash/commands/basectl/tests/workspace.bats` — 15 passed - Workspace clone tests — 5 passed - Real workspace dry-run fan-out — 0 inherited-context warnings, 1 primary history row, 1 run bundle - `./bin/base-test` — 1,115 Python and 899 BATS passed - ShellCheck and `git diff --check` passed ## Docs Impact Updated `docs/observability.md` to document that inherited Base children do not write separate completion records or mutate the parent lifecycle. Workspace clone semantics and repository materialization behavior are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent delegated Base child invocations from finalizing an inherited parent run bundle. This removes repeated invalid-context warnings during workspace fan-out while preserving shared logging and history ownership.
Issue
Fixes #2069
Validation
bats cli/bash/commands/basectl/tests/runtime-dispatch.bats— 40 passedbats cli/bash/commands/basectl/tests/workspace.bats— 15 passedBASE_CLI_SOURCE_DIR=/Users/rameshhp/work/base-cli/lib/python PYTHONPATH=/Users/rameshhp/work/base-cli/lib/python:lib/python:cli/python /Users/rameshhp/.base.d/base/.venv/bin/python -m pytest cli/python/base_projects/tests/test_workspace_clone.py -q— 5 passedenv -u BASE_HOME BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash BASE_CLI_SOURCE_DIR=/Users/rameshhp/work/base-cli/lib/python BASE_CACHE_DIR=/private/tmp/base-test-run-bundle-2069 ./bin/base-test— 1115 Python and 899 BATS passedgit diff --checkpassedDemo Impact
None.
Notes
Only the invocation that creates a run bundle finalizes it. Inherited children validate the bundle but leave its lifecycle to the parent. No workspace clone, manifest, authentication, or GitHub API semantics change.