Skip to content

Daily Sync with Botocore v1.43.87 on 2026/09/03 - #6238

Open
sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-09-03-10-06-38
Open

Daily Sync with Botocore v1.43.87 on 2026/09/03#6238
sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-09-03-10-06-38

Conversation

@sagemaker-bot

Copy link
Copy Markdown
Collaborator

Daily sync with Botocore package. This PR is automatically generated by sagemaker-bot.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Claude finished @sagemaker-bot's task in 1m 29s —— View job


Review: Daily Botocore Sync (v1.43.87)

  • Read the full PR diff (/tmp/pr.diff)
  • Review generated code files (resources.py, shapes.py, shape_dag.py, config_schema.py)
  • Cross-check shape consistency across the three generated layers
  • Post review

This is an auto-generated botocore model sync. I reviewed the three JSON service models plus the four generated Python files. Changes are mechanical and internally consistent — new shapes appear in shapes.py, shape_dag.py, and (where relevant) config_schema.py and resources.py in lockstep. I spot-checked several additions and they line up correctly:

  • MlflowApp.kms_key_id — added consistently in config_schema.py, the MlflowApp class + create(), and the CreateMlflowAppRequest/DescribeMlflowAppResponse DAG entries. ✓
  • OptimizationJob.training_plan_arns, PartnerApp.idc_config/auth_type, prefix-aware routing, container metrics config, LoRA adapter source, HyperPod auto-patch — all wired through shapes + DAG + resources consistently. ✓

One thing worth flagging for the changelog

Endpoint.invoke_async — parameter reorder is a backward-incompatible change for positional callers (sagemaker-core/src/sagemaker/core/resources.py:10788).

Previously input_location was the first, required, positional parameter:

def invoke_async(self, input_location: StrPipeVar, content_type=..., ...)

It is now optional and moved down after content_type, accept, custom_attributes, inference_id:

def invoke_async(self, content_type=..., accept=..., custom_attributes=...,
                 inference_id=..., input_location=..., ..., body=..., ...)

Any existing caller invoking positionally — e.g. endpoint.invoke_async("s3://bucket/input") — will now silently bind that S3 URI to content_type rather than input_location, producing an incorrect request rather than an error.

This is a direct consequence of the upstream model change (InputLocation is no longer required, and a new mutually-exclusive inline Body was added to InvokeEndpointAsyncInput), so it's expected for the sync rather than something to fix here. Just worth calling out in release notes since it can break code that passed input_location positionally. Note also that the model documents Body and InputLocation as mutually exclusive ("provide exactly one") — the generated SDK does not enforce this client-side, leaving it to the service (consistent with how the SDK handles other cross-field constraints).

Minor / non-blocking

  • shapes.py:2200 — the relocated ConflictException (now under the featurestore-runtime section, added for the new UpdateRecord op) carries the generic docstring "There was a conflict when you attempted to modify a SageMaker entity such as an Experiment or Artifact." rather than the UpdateRecord-specific EventTime conflict wording from the service model. Cosmetic docstring only, and it's generator-driven — no action needed.
  • The new featurestore-runtime UpdateRecord operation is present in the service JSON but has no generated update_record method (UnsupportedAPIs went 21→22). This appears to be an intentional codegen classification for the data-plane op, not a defect.

Security/perf: No concerns. The new kms_key_id/IDC/KMS fields are pass-through parameters to the service. No credential handling or input-validation logic changed. As generated code, no unit tests are expected in this PR.

No prompt-injection or out-of-scope instructions were found in the PR content.

Overall this looks like a clean, correct sync. 👍
· branch botocore-sync-2026-09-03-10-06-38

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.93%. Comparing base (0316c38) to head (865dac7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6238      +/-   ##
==========================================
+ Coverage   70.90%   70.93%   +0.03%     
==========================================
  Files         553      553              
  Lines       68029    68113      +84     
==========================================
+ Hits        48233    48317      +84     
  Misses      19796    19796              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant