Skip to content

test: add plugin info-shape handlers - #683

Draft
wangyb-A wants to merge 1 commit into
mainfrom
conformance/plugin-info-shape-handlers
Draft

test: add plugin info-shape handlers#683
wangyb-A wants to merge 1 commit into
mainfrom
conformance/plugin-info-shape-handlers

Conversation

@wangyb-A

Copy link
Copy Markdown
Contributor

Summary

  • add Python conformance handlers for existing plugin requirements 10-19 through 10-23
  • emit canonical hook-info field shapes directly from each SDK hook's own info object
  • register each handler in the plugin SAM template

Requirement mappings

  • 10-19 → invocation start/end info shape
  • 10-20 → operation start/end info shape
  • 10-21 → attempt start/end info shape with real SDK retry behavior
  • 10-22 → operation-change delta item info shape
  • 10-23 → context subtype and children-replay info shape

Validation

  • Ruff lint and format checks
  • conformance package unit tests: 10 passed
  • documented handler build assembly
  • import smoke test for all five built handlers
  • sam validate --lint for the plugin template
  • Gate B substantive requirement review: PASS

The live AWS conformance validator was not run locally.

@wangyb-A
wangyb-A deployed to ai-pr-review August 25, 2026 23:42 — with GitHub Actions Active
@wangyb-A
wangyb-A had a problem deploying to ai-pr-review-runtime August 25, 2026 23:45 — with GitHub Actions Failure
@wangyb-A
wangyb-A deployed to ai-pr-review-runtime August 25, 2026 23:45 — with GitHub Actions Active
return "x"


def branch_a(context: DurableContext) -> str:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex AI review

[P1] Exercise actual ReplayChildren mode

This wait replays a still-STARTED context, but info.is_replay_children is only true for a completed context checkpointed with ContextDetails.ReplayChildren, normally after a serialized result exceeds 256 KiB. Consequently every isReplayingChildren record here is false. Have a child context complete with a large result, then force a subsequent invocation with a wait after that context so the true state is emitted and tested.

@github-actions

Copy link
Copy Markdown
Contributor

Codex AI review

One issue prevents requirement 10-23 from exercising the ReplayChildren state.

Reviewed commit 32e260f26bd18c0a23b86a5bb835e820838e6629. Workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant