test: add plugin info-shape handlers - #683
Draft
wangyb-A wants to merge 1 commit into
Draft
Conversation
wangyb-A
had a problem deploying
to
ai-pr-review-runtime
August 25, 2026 23:45 — with
GitHub Actions
Failure
| return "x" | ||
|
|
||
|
|
||
| def branch_a(context: DurableContext) -> str: |
Contributor
There was a problem hiding this comment.
Codex AI review
[P1] Exercise actual ReplayChildren mode
This wait replays a still-STARTED context, but info.is_replay_children is only true for a completed context checkpointed with ContextDetails.ReplayChildren, normally after a serialized result exceeds 256 KiB. Consequently every isReplayingChildren record here is false. Have a child context complete with a large result, then force a subsequent invocation with a wait after that context so the true state is emitted and tested.
Contributor
Codex AI reviewOne issue prevents requirement 10-23 from exercising the ReplayChildren state. Reviewed commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
10-19through10-23Requirement mappings
10-19→ invocation start/end info shape10-20→ operation start/end info shape10-21→ attempt start/end info shape with real SDK retry behavior10-22→ operation-change delta item info shape10-23→ context subtype and children-replay info shapeValidation
sam validate --lintfor the plugin templateThe live AWS conformance validator was not run locally.