feat(eval): online-eval BYO execution role, remove auto-provisioning (P3) - #2070
Closed
jariy17 wants to merge 1 commit into
Closed
feat(eval): online-eval BYO execution role, remove auto-provisioning (P3)#2070jariy17 wants to merge 1 commit into
jariy17 wants to merge 1 commit into
Conversation
jariy17
marked this pull request as ready for review
August 22, 2026 15:56
jariy17
force-pushed
the
feat/online-eval-byo-role
branch
from
August 25, 2026 19:18
5d1dca8 to
ca0ec02
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2070 +/- ##
============================================
+ Coverage 97.36% 97.48% +0.11%
============================================
Files 424 423 -1
Lines 25571 25261 -310
============================================
- Hits 24897 24625 -272
+ Misses 674 636 -38 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Hweinstock
approved these changes
Aug 26, 2026
Contributor
Author
|
| is this vision here that we'll come back to support automatic role creation once we have a general solution for imperative? Yes, but after today's standup. I'll leave this feature for now and implement automatic role creation later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
eval online-evalnow requires the caller to bring their own execution role, and the CLI-side auto-provisioning is deleted entirely.create:--role-arnis now required (guard rejects a missing value withrequired option '--role-arn <role-arn>' not specified). It is passed straight through toCreateOnlineEvaluationConfig.update:--role-arnstays optional (replace); when omitted the service keeps the existing role.Removed
src/core/onlineEvalExecutionRole.tsx(+ its unit test) — the whole default-role provisioning module:grantOnlineEvalScope/revokeOnlineEvalScope/onlineEvalExecutionRoleName/scopePolicyName/executionPolicy/accountIdFromRoleArn.create's auto-provision fallback and theretryWhileRolePropagatesIAM-propagation retry (a caller role that cannot be assumed now fails fast).update's--update-roleflag, the managed-role grant/revoke/KMS re-scope block, and the entire role-scope-warning path (RoleScopeWarningtype, stderr advisory).updateOnlineEvaluationConfignow returns the bareUpdateOnlineEvaluationConfigResponse.core/eval.tsx:evaluatorKmsKeys,logGroupNamesOf(create no longer callsGetEvaluatoror scopes a role).Stack
P1 #2067 → P2 #2069 → P3 (this) → P4 TUI get/list. See the plan artifact.
Verification
tsc --noEmitclean.UPDATINGrace by adding asettle()before delete. Goldens now show the caller-supplied role; noAgentCoreOnlineEval-*provisioned role, no IAM (GetRole/PutRolePolicy) fixtures. Verified noagentcore_cli_online_eval*residue in the account afterward.