Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| */ | ||
| internal data class DiscoveryResponse( | ||
| @SerializedName("alternatives") | ||
| val alternatives: List<Alternative> |
There was a problem hiding this comment.
alternatives is non-null but Gson can leave it null. Guarded by .orEmpty(), but List? is more honest.
There was a problem hiding this comment.
Why would Gson would it leave it as null ? alternatives is a mandatory list as per the schema definition
| mavenCentral() | ||
| } | ||
| dependencies { | ||
| classpath "org.jetbrains.kotlin:compose-compiler-gradle-plugin:2.0.21" |
There was a problem hiding this comment.
Hardcoded 2.0.21. Use $kotlin_version so it can't drift on the next Kotlin bump.Its up to you as its sample just flagging
There was a problem hiding this comment.
Not a hard requirement but will update it to keep consistency
|
New public entry point EmbeddedAuthClient added with no README mention. |
| @@ -0,0 +1,167 @@ | |||
| package com.auth0.android.embedded | |||
There was a problem hiding this comment.
Add one await() coroutine test — only .execute() covered.
There was a problem hiding this comment.
Added a test case for the same
|
sample-embedded module — is this meant to ship in the repo (and be built by CI going forward), or is it a temporary demo to be removed before merge? |
This will be added and pushed to GH but won't be build in CI . Neither is our existing sample app is being build in CI |
|
This branch has not been deployed
2 participants
Changes
This PR adds the support for the
/e/discoveryendpoint as part of the embedded authorize initiative. This API returns all the grant types enabled for a client. It takes an optional connection parameter to narrow down the grant types for a particular connectionTesting
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. Since this library has unit testing, tests should be added for new functionality and existing tests should complete without errors.
This change adds unit test coverage
This change has been tested on the latest version of the platform/language or why not
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors