Skip to content

chore(deps): update dependency oxlint-tsgolint to v7 - #1295

Open
renovate[bot] wants to merge 2 commits into
masterfrom
renovate/oxlint-tsgolint-7.x
Open

renovate[bot] wants to merge 2 commits into
masterfrom
renovate/oxlint-tsgolint-7.x

Conversation

@renovate

@renovate renovate Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Note

quick fixes for renovate.

Diagnosis

The 5 errors at test/tsconfig.json:0:0 with empty messages were one TS6059 per offending root file, not 5 lint violations. The messages were lost in the GitHub Actions annotation, not by oxlint. Run locally, they read:

test/tsconfig.json: error typescript(tsconfig-error): Invalid tsconfig help: File
'.../src/index.ts' is not under 'rootDir' '.../test'.
'rootDir' is expected to contain all source files.

The config is invalid on its own, independent of oxlint. Plain tsc -p test/tsconfig.json reports the identical 5 errors on master today, with tsgolint 0.22.1 still installed:

error TS6059: File '.../src/index.ts' is not under 'rootDir' '.../test'.
  The file is in the program because:
    Matched by include pattern '../src' in '.../test/tsconfig.json'

So this is a latent misconfiguration that the upgrade exposed, not a tsgolint regression.

Ruled out:

  • types: ["vitest/globals"]node_modules/vitest/globals.d.ts exists and resolves under vitest 5.
  • oxlint / tsgolint version pairingoxlint@1.82.0 drives oxlint-tsgolint@7.0.2001 fine. No peer warnings, no oxlint bump needed.

Fix

rootDir: "."rootDir: ".." in test/tsconfig.json.

rootDir has to contain every file in the program. This config includes both test/** and ../src, so the repo root is the only value that covers them. rootDir is inert here anyway (noEmit: true) — it only existed to override the parent's rootDir: "src", and "." was the wrong override.

Verified: tsc -p test/tsconfig.json goes from 5 TS6059 errors to 0, and oxlint --type-aware exits 0.

The alternative — dropping ../src from include — was rejected. It silences tsgolint but leaves the config broken: tsc still reports 95 TS6059 violations, because the src files are still pulled into the program as imports. That masks the problem rather than fixing it.

Checks

pnpm run lint && pnpm run format && pnpm run build && pnpm run test:local all pass locally (564 tests passed, 4 skipped).

Notes

  • This branch is Renovate's own. Renovate force-pushes over it, which would drop the test/tsconfig.json commit and make the lint failure come back. If that happens, re-apply the one-line change.
  • The branch is based on 1ba4feac and master has since moved to 5ba9841e. Left un-rebased on purpose: rebasing triggers a full peer re-resolve of the website workspace and turns a 37-line lockfile diff into ~1600 lines.

🤖 Generated with Claude Code

@renovate
renovate Bot requested review from DaveHanns and l2ysho as code owners July 22, 2026 22:34
@renovate
renovate Bot force-pushed the renovate/oxlint-tsgolint-7.x branch 12 times, most recently from b1c2f0c to 4450a27 Compare July 30, 2026 16:38
@renovate
renovate Bot force-pushed the renovate/oxlint-tsgolint-7.x branch 4 times, most recently from e060c1b to 9e6c32e Compare August 3, 2026 09:53
@renovate
renovate Bot force-pushed the renovate/oxlint-tsgolint-7.x branch 6 times, most recently from b75fef4 to c58c866 Compare August 11, 2026 08:22
@renovate
renovate Bot force-pushed the renovate/oxlint-tsgolint-7.x branch 4 times, most recently from 30c89d8 to 0f502a0 Compare August 18, 2026 12:33
@renovate
renovate Bot force-pushed the renovate/oxlint-tsgolint-7.x branch 2 times, most recently from 174097c to 63973d9 Compare August 25, 2026 15:12
@renovate
renovate Bot force-pushed the renovate/oxlint-tsgolint-7.x branch 12 times, most recently from 088acf8 to e4bf07c Compare September 8, 2026 18:05
@renovate
renovate Bot force-pushed the renovate/oxlint-tsgolint-7.x branch 15 times, most recently from 99f2d71 to 935fecb Compare September 15, 2026 10:22
renovate Bot and others added 2 commits September 15, 2026 16:06
…ludes

test/tsconfig.json includes ../src but pinned rootDir to ".", so every
src file in the program sat outside rootDir (TS6059). tsgolint 0.22
swallowed tsconfig load errors; tsgolint 7 surfaces them, which broke
`oxlint --type-aware`.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@renovate

renovate Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-builders Issues owned by the Builders team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants