[ZEPPELIN-6516] Add visualization rendering E2E coverage - #5474
Open
miinhho wants to merge 2 commits into
Open
Conversation
Member
|
Passing only the table test also counts all five charts as successful in the coverage report. I've put together an example fix that adds each chart's annotation when its test step is reached. Please take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Ths PR adds Playwright E2E coverage for Zeppelin's table and G2-based chart visualizations.
The test creates deterministic '%table' output through a notebook paragraph and verifies:
Since G2 renders charts on canvas, checking only that a canvas element is visible is not sufficient. The test also inspects the canvas alpha channel and verifies that it contains rendered pixels.
A dedicated
NotebookVisualizationPagePage Object is added to isolate visualization selectors, table locators, chart canvas locators, and canvas-rendering inspection from the scenario code.Todos
What type of PR is it?
Improvement
What is the Jira issue?
How should this be tested?
Start the Zeppelin backend, then run the focused Chromium E2E test:
cd zeppelin-web-angular npm run e2e:fast -- tests/notebook/paragraph/visualization-rendering.spec.tsQuestions: