WW-3226 test: pin which value wins for each alias/params ordering - #1918
Merged
Conversation
The docs now promise that a directly submitted parameter wins when alias runs before params, and that the alias overrides it when alias runs after params. Cover both orderings so the promise is enforced. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
lukaszlenart
force-pushed
the
WW-3226-alias-params-ordering-test
branch
from
September 12, 2026 07:52
04cd361 to
c8cbdc1
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to WW-3226.
WW-3226 asked for an
overwriteflag onAliasInterceptor. Triage showed the behaviour is already decided by interceptor ordering:aliasandparamsboth set the target property when they run, so whichever runs last wins. struts-site#329 documents that; this PR pins it with two tests so the documented promise is enforced:aliasbeforeparams(thedefaultStackorder) — the directly submitted parameter wins.paramsbeforealias— the alias overrides the submitted parameter.Both tests also assert the source property bound, so a run where
paramsbinds nothing fails instead of passing vacuously. Test-only; no production change. The ticket itself is being closed as Won't Fix.Security review: clean — test-only diff, no shipped code touched.
🤖 Generated with Claude Code