Skip to content

Add checkstyle auto-fix tooling - #9017

Open
sercuzz8 wants to merge 3 commits into
apache:masterfrom
sercuzz8:sketch-solution
Open

Add checkstyle auto-fix tooling#9017
sercuzz8 wants to merge 3 commits into
apache:masterfrom
sercuzz8:sketch-solution

Conversation

@sercuzz8

@sercuzz8 sercuzz8 commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

After this comment, implement a groovy tool to auto fix checkstyle violation to avoid post hoc fixes

@sercuzz8
Add checkstyle auto-fix tooling
f3e1c38 
Runs a Groovy-based auto-fixer (checkstyle-autofix.groovy) via
gmavenplus-plugin at the validate phase, before maven-checkstyle-plugin,
to auto-correct a subset of storm_checkstyle.xml violations
(FileTabCharacter, colon-spacing, CommentsIndentation, CustomImportOrder)
ahead of the checkstyle check. Fixer parameters are read directly from
the active ruleset XML rather than a preset formatter style.

storm.checkstyle.config (root pom) picks the active ruleset basename for
both the fixer and maven-checkstyle-plugin's configLocation.
@sercuzz8
Implement groovy plugin to autofix checkstyle violations
17796cd
@reiabreu

reiabreu commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

@GGraziadei are you happy that this fulfils your request?

@GGraziadei

GGraziadei commented Sep 5, 2026

Copy link
Copy Markdown
Member

Hi @sercuzz8,
Good attempt! However, this plugin doesn’t fix all the warnings.
Have you tried to add more rules for org.codehaus.gmavenplus? Have you tried a different tool (with a parser support)?
Otherwise, I propose we keep the code changes and formatting, but exclude this plugin from mvn validate.

@GGraziadei

GGraziadei commented Sep 18, 2026

Copy link
Copy Markdown
Member

Hi @sercuzz8 any updates on this PR?

@sercuzz8

sercuzz8 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

Hello @GGraziadei,
I am sorry for the delay. I have been trying to either expand this solution or use other tools (Openrewrite, Spotless) to eradicate warning.
Unfortunately I have not managed to overcome those regarding line length as breaking them sometimes breaks compilation in the process.
Given these conditions, I suppose that the best idea would be to remove this plugin from the validate, as you said.
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sercuzz8 @reiabreu @GGraziadei