SOLR-18417: Remove PingRequestHandler and related code - #4874
SOLR-18417: Remove PingRequestHandler and related code#4874gerlowskija wants to merge 4 commits into
Conversation
PingRequestHandler has largely been superseded by HealthcheckHandler (or
even SystemInfoHandler) which do healthchecks at the node-level instead
and tend to be much more compatible with typical load balancers.
This commit deprecates PingRequestHandler and the corresponding SolrPing
class in SolrJ. Removal will occur in a subsequent ('main'-only)
commit.
Removes PingRequestHandler, SolrPing, SolrPingResponse, SolrClient.ping(), and various related constants. This follows their deprecation in Solr 10.1.
github-actions
Bot
added
documentation
There was a problem hiding this comment.
this is the change that I am sad about, that all our content, if I understand it right, on monitoring was in this page, and we lose that. We don't have the equivalent of healthcheck.adoc...
There was a problem hiding this comment.
Okay, I went ahead and put a page togther, would love your feedback: #4886
It's meant to be merged after this PR is merged.
There was a problem hiding this comment.
Thanks for taking that on, I've put some review comments on your PR!
|
by the way, solr/webapp/web/css/angular/dashboard.css still has #healthcheck/.ico/.ico-1 selector rules that this PR doesn't touch — they'll become dead CSS once the HTML that used them is deleted. |
Meaning that this PR should remove those CSS bits, right? Happy to do that, just confirming. Extremely low value given how infrequently the (old) Admin UI gets edited, but I wonder if there's some sort of lint-check we could add to catch this... |
I used this linter: "Claude, tell me what Jason is getting wrong in this PR" ;-). Just kidding..... "Can you review this PR and run /simplify and /code-review --medium" and it found that issue. |
|
I shold probably have just done it an dpushed up the change...... |
2 participants
Removes PingRequestHandler, SolrPing, SolrPingResponse,
SolrClient.ping(), and various related constants. This follows their
deprecation in Solr 10.1.
(This PR requires the as-yet-unmerged #4872, and will be left as
a draft until it is merged. See that PR for more discussion around
the deprecation/removal of this functionality.)