Skip to content

SOLR-16390: Migrate list cluster nodes API to JAX-RS - #4865

Merged
epugh merged 6 commits into
apache:mainfrom
iprithv:SOLR-16390-list-cluster-nodes
Sep 9, 2026
Merged

epugh merged 6 commits into
apache:mainfrom
iprithv:SOLR-16390-list-cluster-nodes

Conversation

@iprithv

@iprithv iprithv commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/SOLR-16390

Converts GET /api/cluster/nodes from the homegrown @EndPoint wrapper to JAX-RS, matching ClusterProperty / ListCollections.

  • JAX-RS interface ListClusterNodesApi and typed ListClusterNodesResponse already existed in solr/api
  • ListClusterNodes owns the live-node listing
  • Path and response key nodes are unchanged
  • SolrJ ClusterApi.ListClusterNodes
  • HTTP coverage in SolrCloud (lists live nodes) and standalone (400 when not SolrCloud)

@github-actions github-actions Bot added documentation Improvements or additions to documentation tests cat:api labels Sep 2, 2026
Signed-off-by: prithvi <prithvisivasankar@gmail.com>
@iprithv
iprithv force-pushed the SOLR-16390-list-cluster-nodes branch from cc54ba4 to 26b2e1d Compare September 2, 2026 14:55
@epugh epugh self-assigned this Sep 2, 2026
@epugh
epugh requested a review from gerlowskija September 2, 2026 15:32
@epugh

epugh commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Looks like the old ClusterAPI.getNodes() @EndPoint never got removed — it's still shadowing the new JAX-RS class for real traffic. Confirmed by running ListClusterNodesStandaloneTest, which fails (500 instead of 400) because the request never reaches ListClusterNodes. #4866 removed the analogous legacy methods for the command-status migration — same fix needed here for getNodes.

@epugh

epugh commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

@iprithv if you can confirm my changes to your PR, then I'll merge ;-)

@iprithv

iprithv commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

LGTM, thanks @epugh for finishing off the migration.. good catch on the endpoint shadow and the 500→400 standalone fix.. admin UI cleanup is a nice bonus :)

@epugh epugh added this to the 10.x milestone Sep 9, 2026
@epugh
epugh merged commit c6d595b into apache:main Sep 9, 2026
6 checks passed
@epugh

epugh commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Thank you @iprithv for this. I wanted to layout more tickets to help people, and so I have this ticket https://issues.apache.org/jira/browse/SOLR-18425 with six subtasks ;-)

@dsmiley

dsmiley commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

10x backport problem: c6d595b (SOLR-16390: Migrate list cluster nodes API to JAX-RS #4865) conflicts because its prerequisite is missing: ListClusterNodesResponse.java and the V2 ListClusterNodes API model were introduced on main by #4154 ("Migrate org.apache.solr.cli tools from V1 to V2 APIs"), which has NO milestone and is NOT on branch_10x. PR #4865's own milestone is 10.x.

dsmiley pushed a commit that referenced this pull request Sep 20, 2026
Signed-off-by: prithvi <prithvisivasankar@gmail.com>
Co-authored-by: Eric Pugh <epugh@opensourceconnections.com>
(cherry picked from commit c6d595b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

admin-ui cat:api documentation Improvements or additions to documentation tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants