Conversation
|
@lkishalmi do we have to regenerate something after updating antlr? |
|
https://github.com/search?q=repo%3Aapache%2Fnetbeans+org.netbeans.libs.antlr4.runtime+language%3Axml&type=code its used in many places. Probably better to run all tests at least once before integration. edit: all tests were green |
|
Well, AFAIK, we've changed the build to generate Lexers/Parsers during build time, with the actual ANTLR version in most of the cases. On the top of my head it's the |
|
I did a parallel build an only spot the following difference |
mbien
left a comment
There was a problem hiding this comment.
thanks for diffing the generated code to verify! update looks good to me.
| OpenIDE-Module-Name=Antlr 4 Runtime | ||
| OpenIDE-Module-Short-Description=Antlr Runtime Libraries | ||
| OpenIDE-Module-Long-Description=Contains Antlr 4.11.1 runtime libraries | ||
| OpenIDE-Module-Long-Description=Contains Antlr 4.13.2 runtime libraries |
There was a problem hiding this comment.
btw, good job catching all old versions which were overlooked in past updates
Refresh to the last antlr 4.13.2
remove unused license
fix antlr3 build in java.api.commons