JSF: avoid suggesting UIComponent default attributes on non-component tags - #9606
Conversation
|
To give a visual example, these are the attributes suggestions of For reference: https://jakarta.ee/specifications/faces/4.1/vdldoc/f/ajax |
mbien
added
Java EE/Jakarta EE
|
BTW, I managed to make the web.jsf.editor unit tests work. Can I add another commit to this PR, or is it better to open a new one? |
Please open a new PR for that unless the changes depend on each other. Thank you! |
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
I think this makes sense to me. I left an inline comment and a clarification request to help my understanding. Thank you!
created #9617 - it might be worth merging that (and enabling web.jsf.editor tests in CI) before this |
… tags TagImpl no longer inherits generic UIComponent attributes (like 'rendered') across all facelet tags. Introduce a ComponentTag wrapper so default component attributes are only provided for actual UI/composite components. Add unit tests for the corrections, now CI runs them
a45e7dd to
86a971d
Compare
|
Thank you. |
3 participants
TagImpl no longer inherits generic UIComponent attributes (like 'rendered') across all facelet tags. Introduce a ComponentTag wrapper so default component attributes are only provided for actual UI/composite components.
Add tests for the corrections.