Skip to content

Fix Google DNS bulk record docstring syntax - #2182

Merged
micafer merged 3 commits into
apache:trunkfrom
nightcityblade:fix/issue-1936-docstring-syntax
Sep 1, 2026
Merged

Fix Google DNS bulk record docstring syntax#2182
micafer merged 3 commits into
apache:trunkfrom
nightcityblade:fix/issue-1936-docstring-syntax

Conversation

@nightcityblade

Copy link
Copy Markdown

Fix Google DNS bulk record docstring syntax

Description

Fixes #1936.

The GoogleDNSDriver.ex_bulk_record_changes docstring mixed a field-list
continuation with an unmarked, inconsistently indented dictionary example.
Sphinx/docutils therefore emitted three warnings while generating the API
documentation. This change aligns the continued parameter description and
marks the example as a Python code block, without changing runtime behavior.

Status

Done, ready for review.

Checklist (tick everything that applies)

  • Code linting (flake8 and Black check pass)
  • Documentation (Sphinx 6.2.1 dummy build passes; the three warnings for this docstring are gone)
  • Tests (11 passed in libcloud/test/dns/test_google.py)
  • ICLA (N/A; small documentation-only correction)

@micafer
micafer enabled auto-merge September 1, 2026 11:54
@micafer
micafer merged commit 1f56710 into apache:trunk Sep 1, 2026
17 checks passed
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.58%. Comparing base (99aa044) to head (6f8e55d).
⚠️ Report is 11 commits behind head on trunk.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk    #2182   +/-   ##
=======================================
  Coverage   83.58%   83.58%           
=======================================
  Files         352      352           
  Lines       81808    81808           
  Branches     8769     8769           
=======================================
  Hits        68373    68373           
  Misses      10562    10562           
  Partials     2873     2873           
Files with missing lines Coverage Δ
libcloud/dns/drivers/google.py 82.09% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix syntax issues in docstrings in the code

3 participants