Parquet: Preserve geometry CRS in writer metrics - #18072
Merged
Merged
Conversation
Use the CRS from the Parquet geometry annotation instead of assigning the default CRS to writer-side field metrics. Generated-by: Cursor
huan233usc
force-pushed
the
geo-parquet-bbox
branch
from
September 11, 2026 23:42
a0dd750 to
e3451fd
Compare
huan233usc
changed the title
szehon-ho
approved these changes
Sep 11, 2026
szehon-ho
left a comment
szehon-ho
left a comment
Member
There was a problem hiding this comment.
lgtm, as it is not hooked up yet and fixes the issue
Member
|
Thanks @huan233usc ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pass the CRS from Parquet's geometry logical type annotation to the generic
GeometryWriterinstead of assigningOGC:CRS84unconditionally. This keeps thewriter-side
FieldMetrics.originalTypealigned with the geometry type encoded inthe Parquet schema and removes reliance on
ParquetMetricsreplacing the typelater.
Tests
TestParquetValueWriters.geometryWriterUsesParquetCRSto verify that anon-default CRS is preserved in writer-side metrics.
AI Disclosure