Build: Consolidate ruff config into pyproject.toml - #3883
Merged
kevinjqliu merged 1 commit intoAug 31, 2026
Conversation
Ruff was the only tool still configured outside pyproject.toml. The standalone ruff.toml was added in apache#619 as a workaround for Dependabot failing to parse the Poetry-era pyproject.toml; the project now uses PEP 621 metadata with a setuptools backend, so that workaround no longer applies. Nothing referenced ruff.toml by path, and `ruff check --show-settings` resolves to identical settings before and after the move. Closes apache#3882
gorewilliams
marked this pull request as ready for review
August 31, 2026 12:36
rambleraptor
approved these changes
Aug 31, 2026
rambleraptor
left a comment
rambleraptor
left a comment
Collaborator
There was a problem hiding this comment.
This seems reasonable. It appears that pyproject.toml and ruff.toml have identical settings.
The linters are still passing, which is what we would expect on this change.
kevinjqliu
approved these changes
Aug 31, 2026
kevinjqliu
left a comment
kevinjqliu
left a comment
Contributor
There was a problem hiding this comment.
LGTM
verified the changes are identical :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3882
Ruff was the only tool still configured outside
pyproject.toml(pytest,mypy,coverageanduvall live there).The standalone
ruff.tomlwas introduced in #619 (April 2024) as a workaround for Dependabot failing to parse the project'spyproject.toml. That was the Poetry era;mainis now PEP 621 metadata with a setuptools backend plus[tool.uv], so the parsing path that motivated the split is no longer in use.Changes
ruff.tomlcontents intopyproject.tomlunder[tool.ruff],[tool.ruff.lint],[tool.ruff.lint.pyupgrade],[tool.ruff.lint.isort]and[tool.ruff.format]ruff.tomlNo settings values changed.
Verification
ruff/ruff-formatandnbqa-ruffhooks pass no--config, so Ruff's own discovery picks up[tool.ruff].ruff check --show-settingsoutput is byte-identical before and after, apart from theSettings pathline itself.prek run --all-filespasses.