mod_http2: fix test failures with recent nghttp2 releases - #713
Closed
notroj wants to merge 2 commits into
Closed
Conversation
notroj
force-pushed
the
pytest-maintainer
branch
from
August 25, 2026 19:07
80e2e6b to
28e86ea
Compare
Collaborator
Author
|
@jfclere I'm hoping this will reproduce the mod_h2 test failures - I also see these on Fedora 44 |
Collaborator
Author
notroj
force-pushed
the
pytest-maintainer
branch
from
August 25, 2026 21:01
32118e5 to
72f9d23
Compare
notroj
changed the title
notroj
force-pushed
the
pytest-maintainer
branch
from
August 26, 2026 07:13
72f9d23 to
3ed0448
Compare
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Aug 26, 2026
GitHub: PR #713 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1937467 13f79535-47bb-0310-9956-ffa450edef68
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Aug 26, 2026
(workflow not added yet) * test/travis_before_linux.sh: Build $TEST_NGHTTP2 from its GitHub release tag into $HOME/root/nghttp2. * test/travis_run_linux.sh: For $TEST_NGHTTP2, configure with --with-nghttp2 plus an RPATH, and fail if mod_http2 does not link against it. Honour a preset $PYHTTPD_TARGETS, and pass $PYTEST_ARGS through to make. * Makefile.in (check-all-pytest): Pass $(PYTEST_ARGS) to run-all-tests.sh. * test/README.ci: Document TEST_NGHTTP2, PYHTTPD_TARGETS and PYTEST_ARGS. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> GitHub: PR #713 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1937468 13f79535-47bb-0310-9956-ffa450edef68
notroj
force-pushed
the
pytest-maintainer
branch
from
August 27, 2026 07:38
3ed0448 to
f616cee
Compare
…sed. A stream created but never scheduled (e.g. after a connection-level protocol error) is reclaimed with the session pool rather than destroyed explicitly, which is harmless; use-after-free is still caught by H2_STRM_ASSERT_MAGIC at each use. * modules/http2/h2_stream.c (stream_pool_destroy): Trace-log rather than assert for a stream reclaimed without an explicit destroy. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
nghttp2 promoted various stream errors to connection errors in 1.67.0, which mod_http2 handles differently; the runner image is still on 1.59. * .github/workflows/linux.yml: Add the job. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
notroj
force-pushed
the
pytest-maintainer
branch
from
August 27, 2026 09:56
f616cee to
1e8a9a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.