[fix](ci) Pull MinIO images from Doris Docker Hub - #67908
Merged
hello-stephen merged 1 commit intoSep 13, 2026
Merged
Conversation
### What problem does this PR solve? Issue Number: none Related PR: apache#67897 Problem Summary: PR apache#67897 temporarily moved the MinIO server and client images from Docker Hub to Quay.io after the upstream Docker Hub repositories were removed. Mirror the exact image manifests into the Doris-owned doristhirdpartydocker namespace and update every repository reference to use the project-controlled copies. Pin the two previously untagged sample images to release tags whose manifests match the current Quay.io latest images. ### Release note None ### Check List (For Author) - Test: Manual test - Verified all eight changed YAML files parse successfully. - Verified all seven public Docker Hub tags match the source manifest digests and resolve for linux/amd64 and linux/arm64. - Behavior changed: No. The image contents and runtime configuration are unchanged; only the registry location changes and previously floating sample tags are made explicit. - Does this need documentation: No
Contributor
Author
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
/review |
Contributor
There was a problem hiding this comment.
Automated code review summary
Overall opinion: Approve. I found no blocking or actionable correctness issues.
Critical checkpoints:
- Goal and evidence: The PR replaces all 16 Quay MinIO/mc references across the nine changed files. Anonymous live registry checks resolved all seven destination tags, matched every source/target manifest digest, and confirmed linux/amd64 and linux/arm64 coverage. At review time, the two new fixed release tags also exactly match the former Quay latest manifests.
- Scope and minimality: The patch is limited to image scalar substitutions. Commands, environment, health checks, dependencies, volumes, cleanup, and the existing MINIO_IMAGE override are unchanged.
- Concurrency, lifecycle, and errors: No program concurrency, locking, atomic, static-initialization, or error-handling logic changes. Existing container readiness, initializer ordering, failure behavior, and finally cleanup remain intact; exact manifest identity preserves the required shell, curl, server, and mc paths.
- Configuration, compatibility, and parallel paths: No new dynamic config, protocol, persisted format, FE/BE variable, or rolling-upgrade concern. A repository-wide sweep found zero remaining quay.io/minio references and no missed server/client pair in the migration scope.
- Conditions, tests, results, and observability: No conditional logic or expected-result files change, and no new product logging or metrics are needed. Per the review-runner contract, this review ran no source build, runtime image, or test. The author reports YAML parsing and manual manifest/platform checks; broad green CI is not treated as proof that the Docker-gated regression itself ran.
- Transactions, data writes, and performance: Transactionality, persistence, data visibility, and storage compatibility are not affected. Identical manifests preserve runtime CPU, memory, and I/O behavior; no concrete pull-path performance regression was found.
- Other issues: None substantiated after the main scan, a full-coverage review, a separate registry-risk review, and the final changed-file sweep.
User focus: No additional focus was provided; the full PR was reviewed.
Review completion: Complete at head ed25fb7. Both Round 1 subagents returned NO_NEW_VALUABLE_FINDINGS, all three initial risk items were resolved, and no inline comments were necessary.
morningman
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: none
Related PR: #67897
Problem Summary:
PR #67897 temporarily moved the MinIO server and client images from Docker Hub to Quay.io after the upstream Docker Hub repositories were removed. The required image manifests have now been mirrored into the Doris-owned public
doristhirdpartydockernamespace.This PR updates all 16 references in 9 files to use
doristhirdpartydocker/minioanddoristhirdpartydocker/mc. Existing release tags, startup arguments, environment variables, and test logic remain unchanged. The two previously untagged sample images are pinned to release tags whose manifests match the current Quay.iolatestimages.Release note
None
Check List (For Author)
linux/amd64andlinux/arm64.