[fix](fe) Reserve watershed before exposing shadow indexes - #67247
Draft
Yukang-Lian wants to merge 2 commits into
Draft
Yukang-Lian wants to merge 2 commits into
Yukang-Lian wants to merge 2 commits into
Conversation
### What problem does this PR solve? Issue Number: None Related PR: apache#62946 Problem Summary: Schema change and rollup jobs exposed shadow indexes to load planning before reserving their watershed transaction boundary. A transaction could therefore miss the shadow index while being ordered after the watershed, leaving a rowset version gap that the alter job would not wait for. Reserve the boundary under the same table write lock used to publish the shadow metadata in local and cloud jobs, and keep schema-change jobs pending when the second stability check aborts publication. ### Release note None ### Check List (For Author) - Test: Unit Test - SchemaChangeJobV2Test - RollupJobV2Test - CloudIndexTest - Behavior changed: Yes (shadow indexes are published only after their transaction watershed is reserved) - Does this need documentation: No Co-authored-by: Siyang Tang <tangsiyang@selectdb.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
### What problem does this PR solve? Issue Number: None Related PR: apache#62946 Problem Summary: CheckStyle requires imports to be sorted lexicographically. Place AddRollupOp before AlterOp in CloudIndexTest. ### Release note None ### Check List (For Author) - Test: FE CheckStyle - `cd fe && mvn clean checkstyle:check` (all 74 modules passed) - Behavior changed: No - Does this need documentation: No
Collaborator
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
TPC-H: Total hot run time: 16669 ms |
Contributor
TPC-DS: Total hot run time: 81554 ms |
Contributor
ClickBench: Total hot run time: 14.54 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Yukang-Lian
marked this pull request as draft
September 10, 2026 03:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: #62946
Problem Summary: Schema change and rollup jobs exposed shadow indexes to load planning before reserving their watershed transaction boundary. A transaction could therefore miss the shadow index while being ordered after the watershed, leaving a rowset version gap that the alter job would not wait for. Reserve the boundary under the same table write lock used to publish the shadow metadata in local and cloud jobs, and keep schema-change jobs pending when the second stability check aborts publication.
Release note
None
Check List (For Author)
Co-authored-by: Siyang Tang tangsiyang@selectdb.com