[fix](cloud) Keep delete rowset schemas rowset-local - #67246
Draft
Yukang-Lian wants to merge 1 commit into
Draft
Yukang-Lian wants to merge 1 commit into
Yukang-Lian wants to merge 1 commit into
Conversation
### What problem does this PR solve? Issue Number: None Related PR: apache#62867 Problem Summary: Delete rowsets can carry only the columns needed by their predicates and omit indexes after a light schema change. MetaService treated those inline schemas as authoritative: commit and restore paths could write them to shared schema KV, while get-rowset and retry collision paths could reuse them for normal rowsets with the same schema version. This could produce schema mismatches and fail later normal rowset commits. Keep delete rowset schemas inline and rowset-local, and exclude them from shared schema writes and reuse in both legacy and versioned metadata modes. ### Release note Prevent Cloud MetaService delete rowsets from corrupting or being reused as shared tablet schemas. ### Check List (For Author) - Test: Unit Test - `./run-cloud-ut.sh --run --filter=meta_service_test:MetaServiceTest.DeleteRowsetSchemaStaysRowsetLocal -j 32` - `./build.sh --cloud -j 32` - Behavior changed: Yes (delete rowset inline schemas are no longer shared across rowsets) - Does this need documentation: No Co-authored-by: Siyang Tang <tangsiyang@selectdb.com>
Yukang-Lian
requested review from
gavinchou,
liaoxin01 and
luwei16
as code owners
August 28, 2026 03:35
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
Yukang-Lian
marked this pull request as draft
September 10, 2026 03:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: #62867
Problem Summary: Delete rowsets can carry only the columns needed by their predicates and omit indexes after a light schema change. MetaService treated those inline schemas as authoritative: commit and restore paths could write them to shared schema KV, while get-rowset and retry collision paths could reuse them for normal rowsets with the same schema version. This could produce schema mismatches and fail later normal rowset commits. Keep delete rowset schemas inline and rowset-local, and exclude them from shared schema writes and reuse in both legacy and versioned metadata modes.
Release note
Prevent Cloud MetaService delete rowsets from corrupting or being reused as shared tablet schemas.
Check List (For Author)
./run-cloud-ut.sh --run --filter=meta_service_test:MetaServiceTest.DeleteRowsetSchemaStaysRowsetLocal -j 32./build.sh --cloud -j 32Co-authored-by: Siyang Tang tangsiyang@selectdb.com