[fix](fe) Reject MOW key additions with sync MVs - #67245
Open
Yukang-Lian wants to merge 1 commit into
Open
Conversation
### What problem does this PR solve? Issue Number: None Related PR: apache#62875 Problem Summary: Adding a key column to a merge-on-write unique table updates every visible materialized index schema without updating its synchronous materialized view definition. Queries rewritten to that index can then decode stored rows with the wrong schema and return incorrect values. Reject this unsupported schema change while a visible synchronous materialized view or rollup exists. Users can drop the materialized index, add the key column, and recreate it. Value-column additions remain unchanged. ### Release note Reject adding key columns to merge-on-write unique tables while synchronous materialized views or rollups exist. ### Check List (For Author) - Test: Unit Test - ./run-fe-ut.sh --run org.apache.doris.alter.SchemaChangeHandlerTest#testUniqAddKeyColumnWithSyncMv+testUniqAddKeyColumnWithRollup (2 tests passed) - Behavior changed: Yes (unsafe key-column additions are rejected until synchronous materialized views or rollups are dropped) - Does this need documentation: No Co-authored-by: Siyang Tang <tangsiyang@selectdb.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 16997 ms |
Contributor
TPC-DS: Total hot run time: 83615 ms |
Contributor
ClickBench: Total hot run time: 14.88 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: #62875
Problem Summary: Adding a key column to a merge-on-write unique table updates every visible materialized index schema without updating its synchronous materialized view definition. Queries rewritten to that index can then decode stored rows with the wrong schema and return incorrect values.
Reject this unsupported schema change while a visible synchronous materialized view or rollup exists. Users can drop the materialized index, add the key column, and recreate it. Value-column additions remain unchanged.
Release note
Reject adding key columns to merge-on-write unique tables while synchronous materialized views or rollups exist.
Check List (For Author)
Co-authored-by: Siyang Tang tangsiyang@selectdb.com