fix(grafana): use IS TRUE for boolean comparisons in Copilot adoption… - #9133
Open
Thundercloud12 wants to merge 1 commit into
Open
fix(grafana): use IS TRUE for boolean comparisons in Copilot adoption…#9133Thundercloud12 wants to merge 1 commit into
Thundercloud12 wants to merge 1 commit into
Conversation
Author
|
@stigi Hello! this is my first pr into this repository, picked up an issue which seemed simple, the issue was postgres evaluated it as true and false values and instead threw an error thats why used IS TRUE, works identically across both mysql and postgres |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr-type/bug-fix,pr-type/feature-development, etc.Summary
Fix Grafana panels in the GitHub Copilot Adoption dashboard that render "No data" on PostgreSQL deployments due to boolean/integer comparison type mismatches.
Replaced
= 1with the ANSI-standardIS TRUEfor theused_agentandused_chatcolumns in:Updated both:
grafana/dashboards/postgresql/github-copilot-adoption.jsongrafana/dashboards/mysql/github-copilot-adoption.jsonKept the PostgreSQL and MySQL dashboard definitions in sync to prevent regressions when the dashboards are updated or ported between database dialects.
Does this close any open issues?
Closes #9126
Screenshots
N/A — This is a query syntax alignment fix. The affected panels will display user counts instead of "No data".
Other Information
IS TRUEis supported natively by PostgreSQL forBOOLEANvalues and by MySQL for boolean-likeTINYINT(1)values.