test: enable DurationSecond fuzzing - #24772
Open
Theodus wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24772 +/- ##
==========================================
- Coverage 81.52% 81.52% -0.01%
==========================================
Files 1123 1123
Lines 405970 405970
Branches 405970 405970
==========================================
- Hits 330978 330974 -4
- Misses 55627 55630 +3
- Partials 19365 19366 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Rich-T-kid
approved these changes
Aug 29, 2026
Comment on lines
+136
to
+138
| // Restrict Duration(Seconds) to values that pretty-print as distinct durations. | ||
| // Out-of-range values print as `<invalid>`, which could make unequal batches | ||
| // compare equal after pretty-printing. |
Contributor
There was a problem hiding this comment.
nit: we could probably trim this comment
Contributor
Author
There was a problem hiding this comment.
I've made the comment more terse in 948812c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A — this restores fuzz coverage disabled by a now resolved upstream Arrow issue.
Rationale for this change
DurationSecondfuzzing was disabled after an Arrow pretty-printing panic (arrow-rs#7533). The panic was fixed in arrow-rs#7534.The existing generator range restriction remains necessary: out-of-range values print as
<invalid>, which could make unequal batches compare equal in the fuzzer's pretty-print comparison.What changes are included in this PR?
duration_secondsfuzz column.Are these changes tested?
Yes. The existing scalar and aggregation fuzz tests pass with
DurationSecondenabled.Are there any user-facing changes?
No.